Add Source Identifier for Feather compatibility.#129
Merged
StephenDev0 merged 1 commit intoStephenDev0:mainfrom Apr 14, 2025
Merged
Add Source Identifier for Feather compatibility.#129StephenDev0 merged 1 commit intoStephenDev0:mainfrom
StephenDev0 merged 1 commit intoStephenDev0:mainfrom
Conversation
Feather relies on the source having an "identifier" key. Re-adding ```"identifier": "com.stik.sj"``` to the root should fix this.
neoarz
approved these changes
Apr 14, 2025
Collaborator
|
I wondered why that was there when I rewrote the json. Glad to hear it was necessary and fixed! |
Contributor
Author
I think the AltStore spec also used to mandate it. |
Collaborator
|
Probably, it just wasn't in the current docs for Alt or Side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feather relies on the source having a root "identifier" key. #126 broke this. Re-adding
"identifier": "com.stik.sj"to the root fixes this.